dmraid: patch to fix users of dmraid when using musl#42470
Merged
dtzWill merged 1 commit intoNixOS:masterfrom Jun 24, 2018
Merged
dmraid: patch to fix users of dmraid when using musl#42470dtzWill merged 1 commit intoNixOS:masterfrom
dtzWill merged 1 commit intoNixOS:masterfrom
Conversation
I hoped that setting -D_GNU_SOURCE in the build would avoid the need for this patch -- but that only fixes the build itself, this patch adds the define so headers work elsewhere. Particularly, this fixes libblockdev w/musl -- before this change it fails to "detect" headers for dmraid.h since it doesn't compile.
dtzWill
changed the title
Member
Author
|
Eep sorry should've been clearer with title :). |
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: dmraid Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: dmraid Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: dmraid Partial log (click to expand)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hoped that setting -D_GNU_SOURCE in the build would avoid
the need for this patch -- but that only fixes the build itself,
this patch adds the define so headers work elsewhere.
Particularly, this fixes libblockdev w/musl -- before this change
it fails to "detect" headers for dmraid.h since it doesn't compile.
Follow-on to more completely fix what was started in #42198.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)